[DFS_BFS] 10월 10일 #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingulmangul
approved these changes
Oct 13, 2023
|
|
||
| int main() | ||
| { | ||
| vector<vector<int>> board(19, vector<int>(19, 0)); // 19x19 바둑판 초기화 |
There was a problem hiding this comment.
P2. 바둑판의 크기(19)가 초기화할 때, for문을 돌 때 반복적으로 사용되는데 상수로 정의하면 어떤가요? 자주 사용되는 숫자 같은 경우에는 따로 상수로 정의해서 사용하는게 가독성도 좋고 실수의 위험도 줄여줄 수 있어요!
Comment on lines
+7
to
+10
| bool isInside(int x, int y) | ||
| { | ||
| return x >= 0 && x < 19 && y >= 0 && y < 19; | ||
| } |
There was a problem hiding this comment.
좌표의 유효성을 체크하는 부분을 따로 함수로 분리하셨네요! 코드가 깔끔하고 의미도 명확해보여서 좋은 것 같습니다 👍
Comment on lines
+59
to
+67
| if (board[i][j] != 0) | ||
| { // 빈 칸이 아닌 경우 | ||
| int result = checkWin(board, i, j); // 승리 여부 확인 | ||
| if (result != 0) | ||
| { // 승부가 결정된 경우 | ||
| cout << result << '\n' << i + 1 << ' ' << j + 1 << '\n'; // 승리한 플레이어와 위치 출력 | ||
| return 0; | ||
| } | ||
| } |
There was a problem hiding this comment.
P2. 인덴테이션은 가능하면 적게 유지하는게 좋아요! 중첩 if문 대신 continue를 사용해서 빈 칸인 경우 패스를 하고, 그 다음에 승리 여부를 확인하는 건 어떨까요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
###과제제출
기존제출:
1325.cpp
19538.cpp
2615.cpp
4963.cpp
게임_맵_최단거리.cpp