Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwakrhkr59
approved these changes
Aug 25, 2023
| if (abs(tr_w)>tr){ | ||
| diet_life+=floor(tr_w/2.0); | ||
| } | ||
| w0+=diet_eat - day_life - diet_ex; |
| int w0=w1; | ||
| int tr_w; | ||
|
|
||
| for(int i=0;i<n;i++){ |
There was a problem hiding this comment.
n은 이 for문 외에서는 사용되지 않는 변수네요! 이런 경우에는 while(n--)로도 간단하게 표현할 수 있을 것 같네요😊
sawoll
approved these changes
Aug 25, 2023
Comment on lines
+11
to
+19
| int s1_sum=0, s2_sum=0; | ||
| for(int i=0;i<s1.size();i++){ | ||
| if('0'<=s1[i] && s1[i]<='9'){ | ||
| s1_sum+=s1[i]-'0'; | ||
| } | ||
| if('0'<=s2[i] && s2[i]<='9'){ | ||
| s2_sum+=s2[i]-'0'; | ||
| } | ||
| } |
There was a problem hiding this comment.
아주 깔끔한 로직으로 비교함수cmp를 잘 구현해 주셨네요!😊 핵심인 자릿수 합 구하기도 잘 작성해 주셨습니다. cmp에는 문제의 세 가지 조건을 비교하는 부분만 남기고, 이 부분은 따로 함수로 빼내어 cmp에서 호출하여 사용한다면 더 깔끔한 코드가 될 수 있을 것 같습니다!👍👍
Comment on lines
+13
to
+15
| if('0'<=s1[i] && s1[i]<='9'){ | ||
| s1_sum+=s1[i]-'0'; | ||
| } |
There was a problem hiding this comment.
그리고, string헤더의 isdigit 함수를 이용하여 문자의 숫자 여부를 판별할 수 있다는 점도 고려해 주시면 좋을 것 같습니다.😊
Comment on lines
+21
to
+28
| sort(arr.begin(), arr.end()); | ||
|
|
||
| for(int i=0;i<m;i++){ | ||
| cin >> stm; | ||
| if(binary_search(arr.begin(), arr.end(), stm)){ | ||
| num++; | ||
| } | ||
| } |
There was a problem hiding this comment.
sort와 이진탐색을 이용하여 문제를 풀어 주셨네요!👍그런데, 직접 값을 정렬해 주지 않아도 값을 삽입하면 정렬된 상태로 저장해 주는 컨테이너가 있었죠! 그걸 사용해 보면 어떨까요?😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
인적사항
학번: 2071079
이름: 이하린
과제제출
기존 제출: 19636, 1431, 14425
추가 제출: