Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page for uploading json files from tenor to configure persons and orgs #61

Merged
merged 7 commits into from
Nov 2, 2023

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Oct 12, 2023

Now you can open a separate tab on the localtest site and upload tenor
kildedata to localtest internal storage. If there are relevant tenor files
in storage, those will replace Ola Nordmann and Sofie Salt as the localtest
users. You can also select a subset of the files to downoad testData.json
to be used as app local users.

Screenshot 2023-10-12 at 11 00 43

3622.87.84340

In addtition to the user management page, I have included the following changes.

  • Cleanup of login page and use the menu on top instead of links scattered all over the login screen
  • Use latest bootstrap (from CDN, per getboostrap.com instructions)
  • Split HomeController into multiple smaller controllers.
  • Move Reauthenticate button besides the login button and make it a less visible color.
  • Loadbalancer redirects "/" and /Home/* to localtest, so all new controllers got a /Home/[controller]/[action] prefix
  • use only spaces (not mixed with tabs) in nginx.conf.conf

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

… orgs

Now you can open a separate tab on the localtest site and upload tenor
kildedata to localtest internal storage. If there are relevant tenor files
in storage, those will replace Ola Nordmann and Sofie Salt as the localtest
users. You can also select a subset of the files to downoad testData.json
to be used as app local users.

In addtition to the user management page, I have included the following
changes.

* Cleanup of login page and use the menu on top instead of links
  scattered all over the login screen
* Use latest bootstrap (from CDN, per getboostrap.com instructions)
* Split HomeController into multiple smaller controllers.
* Move `Reauthenticate` button besides the login button and make it a
  less visible color.
* Loadbalancer redirects "/" and /Home/* to localtest, so all new
  controllers got a `/Home/[controller]/[action]` prefix
* use only spaces (not mixed with tabs) in nginx.conf.conf
@ivarne ivarne requested a review from tjololo October 12, 2023 06:07
@ivarne
Copy link
Member Author

ivarne commented Oct 12, 2023

Edit: Updated UI to (hopefully) be easier to understand

src/Controllers/DebugUsersController.cs Outdated Show resolved Hide resolved
src/Controllers/FrontendVersionController.cs Outdated Show resolved Hide resolved
src/Controllers/StorageExplorerController.cs Outdated Show resolved Hide resolved
src/Services/Tenor/TenorDataReader.cs Show resolved Hide resolved
The main fix is that `GetTenorStorageDirectory` will create the directory
if it does not exist.
Copy link
Member

@tjololo tjololo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:godmode:

@ivarne ivarne merged commit fc95a47 into main Nov 2, 2023
1 check passed
@ivarne ivarne deleted the ivarne/tenor-users branch November 2, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants