-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
d228eaf
commit 9afb50b
Showing
8 changed files
with
266 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>netstandard2.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| <IsPackable>true</IsPackable> | ||
|
|
||
| <IncludeBuildOutput>false</IncludeBuildOutput> | ||
| <NoPackageAnalysis>true</NoPackageAnalysis> | ||
| <DevelopmentDependency>true</DevelopmentDependency> | ||
| <EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Using Include="System.Collections.Immutable" /> | ||
| <Using Include="Microsoft.CodeAnalysis" /> | ||
| <Using Include="Microsoft.CodeAnalysis.CSharp" /> | ||
| <Using Include="Microsoft.CodeAnalysis.Diagnostics" /> | ||
| <Using Include="Microsoft.CodeAnalysis.CSharp.Syntax" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Pack="false" PrivateAssets="all" Version="4.8.0" /> | ||
| <None Include="$(OutputPath)\$(AssemblyName).dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ; Shipped analyzer releases | ||
| ; https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| ; Unshipped analyzer release | ||
| ; https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md | ||
|
|
||
| ### New Rules | ||
|
|
||
| Rule ID | Category | Severity | Notes | ||
| --------|----------|----------|------- | ||
| ALTINN999 | General | Warning | TestAnalyzer |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| namespace Altinn.App.Analyzers; | ||
|
|
||
| internal static class Diagnostics | ||
| { | ||
| internal static readonly DiagnosticDescriptor UnknownError = Warning( | ||
| "ALTINN999", | ||
| "Unknown analyzer error", | ||
| "Unknown error occurred during analysis: '{0}' {1}" | ||
| ); | ||
|
|
||
| private const string DocsRoot = "https://docs.altinn.studio/app/development/analysis/"; | ||
| private const string RulesRoot = DocsRoot + "rules/"; | ||
|
|
||
| private static DiagnosticDescriptor Warning(string id, string title, string messageFormat) => | ||
| Create(id, title, messageFormat, Category.General, DiagnosticSeverity.Warning); | ||
|
|
||
| private static DiagnosticDescriptor Create( | ||
| string id, | ||
| string title, | ||
| string messageFormat, | ||
| string category, | ||
| DiagnosticSeverity severity | ||
| ) => new(id, title, messageFormat, category, severity, true, helpLinkUri: RulesRoot + id); | ||
|
|
||
| private static class Category | ||
| { | ||
| public const string General = nameof(General); | ||
| } | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Analyzer | ||
| /// </summary> | ||
| [DiagnosticAnalyzer(LanguageNames.CSharp)] | ||
| public class TestAnalyzer : DiagnosticAnalyzer | ||
| { | ||
| /// <summary> | ||
| /// Supported diagnostics | ||
| /// </summary> | ||
| public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => | ||
| ImmutableArray.Create(Diagnostics.UnknownError); | ||
|
|
||
| /// <summary> | ||
| /// Initializer | ||
| /// </summary> | ||
| /// <param name="context"></param> | ||
| public override void Initialize(AnalysisContext context) | ||
| { | ||
| // var configFlags = GeneratedCodeAnalysisFlags.Analyze | GeneratedCodeAnalysisFlags.ReportDiagnostics; | ||
| var configFlags = GeneratedCodeAnalysisFlags.None; | ||
| context.ConfigureGeneratedCodeAnalysis(configFlags); | ||
| context.EnableConcurrentExecution(); | ||
|
|
||
| // context.RegisterCompilationStartAction(OnCompilationStart); | ||
| context.RegisterCompilationAction(OnCompilation); | ||
| context.RegisterSyntaxNodeAction(AnalyzeNode, SyntaxKind.SimpleMemberAccessExpression); | ||
| } | ||
|
|
||
| // private void OnCompilationStart(CompilationStartAnalysisContext context) | ||
| // { | ||
| // } | ||
|
|
||
| private void OnCompilation(CompilationAnalysisContext context) { } | ||
|
|
||
| private void AnalyzeNode(SyntaxNodeAnalysisContext context) | ||
| { | ||
| try | ||
| { | ||
| if (context.Node is not MemberAccessExpressionSyntax memberAccess) | ||
| return; | ||
|
|
||
| if (memberAccess.Name.Identifier.Text != "OpenTelemetry") | ||
| return; | ||
|
|
||
| var symbol = context.SemanticModel.GetSymbolInfo(memberAccess.Expression, context.CancellationToken).Symbol; | ||
| } | ||
| catch (Exception ex) | ||
| { | ||
| context.ReportDiagnostic( | ||
| Diagnostic.Create(Diagnostics.UnknownError, context.Node.GetLocation(), ex.Message, ex.StackTrace) | ||
| ); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
test/Altinn.App.Analyzers.Tests/Altinn.App.Analyzers.Tests.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
|
|
||
| <IsPackable>false</IsPackable> | ||
| <IsTestProject>true</IsTestProject> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="coverlet.collector" Version="6.0.0" /> | ||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" /> | ||
| <PackageReference Include="xunit" Version="2.5.3" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.5.3" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Analyzer.Testing.XUnit" Version="1.1.1" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\src\Altinn.App.Analyzers\Altinn.App.Analyzers.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <Using Include="Xunit" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| using System.Collections.Immutable; | ||
| using Microsoft.CodeAnalysis; | ||
| using Microsoft.CodeAnalysis.CSharp; | ||
| using Microsoft.CodeAnalysis.CSharp.Testing; | ||
| using Microsoft.CodeAnalysis.Diagnostics; | ||
| using Microsoft.CodeAnalysis.Testing; | ||
| using Microsoft.CodeAnalysis.Testing.Verifiers; | ||
| using Verifier = Altinn.App.Analyzers.Tests.CSharpAnalyzerVerifier<Altinn.App.Analyzers.TestAnalyzer>; | ||
|
|
||
| namespace Altinn.App.Analyzers.Tests; | ||
|
|
||
| public static partial class CSharpAnalyzerVerifier<TAnalyzer> | ||
| where TAnalyzer : DiagnosticAnalyzer, new() | ||
| { | ||
| /// <inheritdoc cref="AnalyzerVerifier{TAnalyzer, TTest, TVerifier}.Diagnostic()"/> | ||
| public static DiagnosticResult Diagnostic() => CSharpAnalyzerVerifier<TAnalyzer, XUnitVerifier>.Diagnostic(); | ||
|
|
||
| /// <inheritdoc cref="AnalyzerVerifier{TAnalyzer, TTest, TVerifier}.Diagnostic(string)"/> | ||
| public static DiagnosticResult Diagnostic(string diagnosticId) => | ||
| CSharpAnalyzerVerifier<TAnalyzer, XUnitVerifier>.Diagnostic(diagnosticId); | ||
|
|
||
| /// <inheritdoc cref="AnalyzerVerifier{TAnalyzer, TTest, TVerifier}.Diagnostic(DiagnosticDescriptor)"/> | ||
| public static DiagnosticResult Diagnostic(DiagnosticDescriptor descriptor) => | ||
| CSharpAnalyzerVerifier<TAnalyzer, XUnitVerifier>.Diagnostic(descriptor); | ||
|
|
||
| /// <inheritdoc cref="AnalyzerVerifier{TAnalyzer, TTest, TVerifier}.VerifyAnalyzerAsync(string, DiagnosticResult[])"/> | ||
| public static async Task VerifyAnalyzerAsync(string source, params DiagnosticResult[] expected) | ||
| { | ||
| var test = new Test { TestCode = source, }; | ||
|
|
||
| test.ExpectedDiagnostics.AddRange(expected); | ||
| await test.RunAsync(CancellationToken.None); | ||
| } | ||
|
|
||
| public class Test : CSharpAnalyzerTest<TAnalyzer, XUnitVerifier> | ||
| { | ||
| public Test() | ||
| { | ||
| SolutionTransforms.Add( | ||
| (solution, projectId) => | ||
| { | ||
| var compilationOptions = solution.GetProject(projectId).CompilationOptions; | ||
| compilationOptions = compilationOptions.WithSpecificDiagnosticOptions( | ||
| compilationOptions.SpecificDiagnosticOptions.SetItems(NullableWarnings) | ||
| ); | ||
| solution = solution.WithProjectCompilationOptions(projectId, compilationOptions); | ||
| return solution; | ||
| } | ||
| ); | ||
| } | ||
| } | ||
|
|
||
| internal static ImmutableDictionary<string, ReportDiagnostic> NullableWarnings { get; } = | ||
| GetNullableWarningsFromCompiler(); | ||
|
|
||
| private static ImmutableDictionary<string, ReportDiagnostic> GetNullableWarningsFromCompiler() | ||
| { | ||
| string[] args = { "/warnaserror:nullable" }; | ||
| var commandLineArguments = CSharpCommandLineParser.Default.Parse( | ||
| args, | ||
| baseDirectory: Environment.CurrentDirectory, | ||
| sdkDirectory: Environment.CurrentDirectory | ||
| ); | ||
| var nullableWarnings = commandLineArguments.CompilationOptions.SpecificDiagnosticOptions; | ||
|
|
||
| // Workaround for https://github.com/dotnet/roslyn/issues/41610 | ||
| nullableWarnings = nullableWarnings | ||
| .SetItem("CS8632", ReportDiagnostic.Error) | ||
| .SetItem("CS8669", ReportDiagnostic.Error); | ||
|
|
||
| return nullableWarnings; | ||
| } | ||
| } | ||
|
|
||
| public class UnitTest1 | ||
| { | ||
| [Fact] | ||
| public async Task Test1() | ||
| { | ||
| var code = """ | ||
| using System; | ||
|
|
||
| class Program | ||
| { | ||
| static void Main() | ||
| { | ||
| int i = 0; | ||
| Console.WriteLine(i++); | ||
| } | ||
| } | ||
| """; | ||
|
|
||
| await Verifier.VerifyAnalyzerAsync(code); | ||
| } | ||
| } |