Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/null error in useLanguage #2607

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix/null error in useLanguage #2607

merged 2 commits into from
Oct 21, 2024

Conversation

bjosttveit
Copy link
Member

@bjosttveit bjosttveit commented Oct 21, 2024

Description

It was somehow possible for language to be used with DatamodelsProvider provided (not ContextNotProvided) but still before they had finished loading (value was null). So adding a null coalecence to return empty array in those cases for the public hooks. But this means they cannot be used to determine loading, but the LoadingBlocker uses the state directly so it should still work as before.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@bjosttveit bjosttveit added the kind/bug Something isn't working label Oct 21, 2024
@bjosttveit bjosttveit self-assigned this Oct 21, 2024
Copy link

sonarcloud bot commented Oct 21, 2024

@bjosttveit bjosttveit merged commit b413ad1 into main Oct 21, 2024
17 of 18 checks passed
@bjosttveit bjosttveit deleted the fix/null-error-formDataTypes branch October 21, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant