Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes fetchProcessState from AppQueriesProvider and mocks with jest #2577

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cammiida
Copy link
Contributor

Description

Removes fetchProcessState from AppQueriesProvider to support efforts towards removing AppQueriesProvider altogether (because all queries are static and therefore do not need to be in a context + contexts = tight coupling). Also supports further work with parallel signing.

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@cammiida cammiida added the kind/other Pull requests containing chores/repo structure/other changes label Oct 14, 2024
@cammiida cammiida self-assigned this Oct 14, 2024
@cammiida cammiida force-pushed the refactor-fetching-process-state branch 3 times, most recently from 2faabdf to 4c713f9 Compare October 15, 2024 19:34
@cammiida cammiida force-pushed the refactor-fetching-process-state branch from 4c713f9 to 8f03b89 Compare October 17, 2024 12:41
@cammiida cammiida force-pushed the refactor-fetching-process-state branch from 8f03b89 to 85c68ba Compare October 17, 2024 12:42
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/other Pull requests containing chores/repo structure/other changes quality/debt
Projects
Status: 🔎 Review
Development

Successfully merging this pull request may close these issues.

2 participants