Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Implementing text when saving scopes #14215

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Nov 29, 2024

Description

  • Implementing saved text and spinner when saving scopes

For some reason, my machine does not want me to upload the video of how it works so here are some screenshots:

Initial state:

Skjermbilde 2024-11-29 kl  13 25 24

Loading state:

Skjermbilde 2024-11-29 kl  13 26 01

Saved state:

Skjermbilde 2024-11-29 kl  13 26 15

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (844b3b1) to head (8bafcde).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14215   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files        1803     1805    +2     
  Lines       23505    23521   +16     
  Branches     2719     2722    +3     
=======================================
+ Hits        22438    22454   +16     
  Misses        813      813           
  Partials      254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit comments, but approved the PR. :)

@Ildest Ildest self-requested a review November 29, 2024 12:51
@Annikenkbrathen
Copy link

Bruker vi denne fargen på checkmark ikonet? den så så mørk ut i fohold til tekstene rundt.
Skjermbilde 2024-11-29 kl  16 43 35
--fds-semantic-text-neutral-subtle

Ellers er jeg kjempefornøyd!

@wrt95
Copy link
Contributor Author

wrt95 commented Dec 2, 2024

Bruker vi denne fargen på checkmark ikonet? den så så mørk ut i fohold til tekstene rundt. Skjermbilde 2024-11-29 kl 16 43 35 --fds-semantic-text-neutral-subtle

Ellers er jeg kjempefornøyd!

Så ikke at den skulle være grå - endret nå 😅

@wrt95 wrt95 merged commit ea8ca6c into main Dec 2, 2024
10 checks passed
@wrt95 wrt95 deleted the chore--14204-save-text-maskinporten branch December 2, 2024 08:40
@wrt95 wrt95 linked an issue Dec 2, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add save text to Maskinporten scopes selection
4 participants