Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-editor): enable component poc and feedback form #14210

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

nkylstad
Copy link
Member

Description

Implement switch for enabling new add-component view, with feedback form.
To be used for testing new design concept for ux-editor, specifically for adding components.

Screen.Recording.2024-11-28.at.17.59.29.mov

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 28, 2024
@nkylstad nkylstad changed the title Feat(UI editor)/enable component poc and feedback form Feat(ui-editor)/enable component poc and feedback form Nov 28, 2024
@nkylstad nkylstad changed the title Feat(ui-editor)/enable component poc and feedback form feat(ui-editor): enable component poc and feedback form Nov 28, 2024
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments added😊

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 95.44%. Comparing base (ea8ca6c) to head (8069ba4).

Files with missing lines Patch % Lines
...iners/DesignView/AddItem/ToggleAddComponentPoc.tsx 64.28% 4 Missing and 1 partial ⚠️
...src/containers/DesignView/AddItem/FeedbackForm.tsx 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14210      +/-   ##
==========================================
- Coverage   95.46%   95.44%   -0.03%     
==========================================
  Files        1806     1809       +3     
  Lines       23553    23590      +37     
  Branches     2731     2734       +3     
==========================================
+ Hits        22485    22515      +30     
- Misses        813      819       +6     
- Partials      255      256       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkylstad
Copy link
Member Author

I have updated the paragraph components ++ to use size="sm". It occurs to me that if that is the standard that we expect to use across our solution, we should just implement it as the default in the Studio-components 🤔 So that we don't have to add it manually each time.

@github-actions github-actions bot added the area/overview Area: Related to the overview page label Nov 29, 2024
Copy link
Contributor

@wrt95 wrt95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🥳

@Ildest Ildest self-requested a review November 29, 2024 13:10
Copy link
Contributor

@Ildest Ildest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noen småjusteringer, men du bestemmer @nkylstad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/overview Area: Related to the overview page area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants