-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui-editor): enable component poc and feedback form #14210
base: main
Are you sure you want to change the base?
feat(ui-editor): enable component poc and feedback form #14210
Conversation
…e-component-poc-and-feedback-form
frontend/libs/studio-feedback-form/src/FeedbackForm/Question/YesNoQuestion.tsx
Fixed
Show fixed
Hide fixed
frontend/libs/studio-feedback-form/src/FeedbackForm/Question/YesNoQuestion.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/AddItem/FeedbackForm.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/AddItem/FeedbackForm.tsx
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/AddItem/FeedbackForm.tsx
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/FormDesignerToolbar.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/FormDesignerToolbar.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/FormDesignerToolbar.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments added😊
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14210 +/- ##
==========================================
- Coverage 95.46% 95.44% -0.03%
==========================================
Files 1806 1809 +3
Lines 23553 23590 +37
Branches 2731 2734 +3
==========================================
+ Hits 22485 22515 +30
- Misses 813 819 +6
- Partials 255 256 +1 ☔ View full report in Codecov by Sentry. |
I have updated the paragraph components ++ to use |
frontend/packages/ux-editor/src/containers/DesignView/AddItem/FeedbackForm.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/AddItem/FeedbackForm.test.tsx
Fixed
Show fixed
Hide fixed
frontend/packages/ux-editor/src/containers/DesignView/AddItem/FeedbackForm.test.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/AddItem/FeedbackForm.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 🥳
frontend/app-development/features/overview/components/News/NewsContent/news.nb.json
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/containers/DesignView/AddItem/FeedbackForm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noen småjusteringer, men du bestemmer @nkylstad
Co-authored-by: Gørild Døhl <[email protected]>
Description
Implement switch for enabling new add-component view, with feedback form.
To be used for testing new design concept for ux-editor, specifically for adding components.
Screen.Recording.2024-11-28.at.17.59.29.mov
Verification
Documentation