splitting up more

Altinn · Nov 27, 2024 · 8fc81de · 8fc81de
1 parent 1895ba3
commit 8fc81de
Showing 1 changed file with 25 additions and 20 deletions.
diff --git a/frontend/app-development/features/appPublish/components/DeployDropdown/DeployDropdown.tsx b/frontend/app-development/features/appPublish/components/DeployDropdown/DeployDropdown.tsx
@@ -54,26 +54,18 @@ export const DeployDropdown = ({
 
   return (
     <div className={classes.deployDropDown}>
-      <div>
-        <StudioCombobox
-          size='small'
-          value={selectedImageTag && imageOptions?.length > 0 ? [selectedImageTag] : undefined}
-          label={t('app_deployment.choose_version')}
-          onValueChange={(selectedImageOptions: string[]) =>
-            setSelectedImageTag(selectedImageOptions[0])
-          }
-          disabled={disabled}
-        >
-          {imageOptions.map((imageOption) => {
-            return (
-              <StudioCombobox.Option key={imageOption.value} value={imageOption.value}>
-                {imageOption.label}
-              </StudioCombobox.Option>
-            );
-          })}
-          <StudioCombobox.Empty>{t('app_deployment.no_versions')}</StudioCombobox.Empty>
-        </StudioCombobox>
-      </div>
+      <StudioCombobox
+        size='small'
+        value={selectedImageTag && imageOptions?.length > 0 ? [selectedImageTag] : undefined}
+        label={t('app_deployment.choose_version')}
+        onValueChange={(selectedImageOptions: string[]) =>
+          setSelectedImageTag(selectedImageOptions[0])
+        }
+        disabled={disabled}
+      >
+        <DeployComboboxOptions imageOptions={imageOptions} />
+        <StudioCombobox.Empty>{t('app_deployment.no_versions')}</StudioCombobox.Empty>
+      </StudioCombobox>
       <div className={classes.deployButton}>
         <DeployPopover
           appDeployedVersion={appDeployedVersion}
@@ -86,3 +78,16 @@ export const DeployDropdown = ({
     </div>
   );
 };
+
+type DeployComboboxOptionsProps = {
+  imageOptions: ImageOption[];
+};
+const DeployComboboxOptions = ({ imageOptions }: DeployComboboxOptionsProps): ReactElement[] => {
+  return imageOptions.map((imageOption: ImageOption) => {
+    return (
+      <StudioCombobox.Option key={imageOption.value} value={imageOption.value}>
+        {imageOption.label}
+      </StudioCombobox.Option>
+    );
+  });
+};