Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an endpoint to synchronize the KKR database with updates from the change log #221

Open
wants to merge 182 commits into
base: main
Choose a base branch
from
Open

Add an endpoint to synchronize the KKR database with updates from the change log #221

wants to merge 182 commits into from
+2,311 −1,427

Conversation

Ahmed-Ghanam
Copy link
Contributor

Description

Develop an endpoint to synchronize the KKR database with updates from the change log

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

hggutvik and others added 30 commits September 25, 2024 15:02
@hggutvik
Correct name of container and solution folder
9bed012
@hggutvik
Fix comment typos
5e8c12c
@hggutvik
Use pattern matching for type check
d78a923
@hggutvik
Refactoring GetUserListByUuid to better fit it with the other methods
f7bcce5
@hggutvik
Correct typo in comment
502872c
@hggutvik
Refactoring to arrow function for simplification
9c1185e
@hggutvik
Cleaning up namespace for Core's ServiceCollectionExtensions
148c693
@hggutvik
Add suffix "Service" to IUnitContactPoints
463287d
@hggutvik
Correct namespace ..User.ContactPoints -> Unit.ContactPoints for IUni…
9da782d 
…tContactPointsService
@hggutvik
Simplify list initialization
6b32190
@Ahmed-Ghanam
Merge branch 'organize/clean-architecture' into featur/186-krr-db-schema
9ad68f5
@Ahmed-Ghanam
Generate database models
42def52
@Ahmed-Ghanam
Move the database context class to its own folder
368af63
@Ahmed-Ghanam
Update the ContextClassName attribute
3d0631d
@Ahmed-Ghanam
Implemented an endpoint to retrieve user contact information efficien…
4a9e081 
…tly.
@Ahmed-Ghanam
Organize each component into its appropriate namespace
d459308
@Ahmed-Ghanam
Remove the unused dependencies and improve the service collection ext…
6b9c2f3 
…ension methods
@Ahmed-Ghanam
Implement a simple validation logic
da1535b
@Ahmed-Ghanam
Specify the expected request and response content types
4be6d04
@Ahmed-Ghanam
Code refactoring to achieve a clean separation of concerns, enhance f…
50f9afd 
…lexibility, and improve the maintainability and testability
@Ahmed-Ghanam
Code refactoring
f518723
@Ahmed-Ghanam
Keep the validation in the service layer and use the AutoMapper to mo…
220239b 
…ve mapping logic out of service.
@Ahmed-Ghanam
Merge branch 'main' into feature/192-krr-endpoints
17ee5f4
@Ahmed-Ghanam
Add a number of unit tests
393fa8b
@Ahmed-Ghanam
Merge branch 'main' into feature/192-krr-endpoints
7cf18d6
@Ahmed-Ghanam
Improve the unit tests
635fe89
@Ahmed-Ghanam
Code refactoring
e4b42b1
@Ahmed-Ghanam
Add a validation rule to validate national security numbers
98d7786
@Ahmed-Ghanam
Rearrange core extensions
5f0cc46
@Ahmed-Ghanam
Organize the matched SSN and the unmatched SSN in a respone object
b595849
@Ahmed-Ghanam Ahmed-Ghanam mentioned this pull request Oct 18, 2024
Open
1 task
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
61.0% Coverage on New Code (required ≥ 65%)
51.61% Condition Coverage on New Code (required ≥ 65%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SandGrainOne SandGrainOne Awaiting requested review from SandGrainOne

@hggutvik hggutvik Awaiting requested review from hggutvik

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ahmed-Ghanam @hggutvik @SandGrainOne