Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement keyword-based dynamic text replacement #657

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

Implement keyword-based dynamic text replacement #657

wants to merge 47 commits into from

Conversation

Ahmed-Ghanam
Copy link
Contributor

Description

This pull request introduces support for placeholder keywords in notification texts, enabling dynamic personalization based on recipient-specific data. These placeholders allow us to dynamically replace predefined keywords in text with the corresponding recipient's information during runtime.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ahmed-Ghanam
Extend the lookup logic to check for the recipientNumber keyword
625a92f
@Ahmed-Ghanam
Improve the members documentation
4f172ca
@Ahmed-Ghanam
Add a new property to whether the template contains any recipient num…
cb5cf44 
…ber placeholders
@Ahmed-Ghanam
Improve type documentation
5919ddb
@Ahmed-Ghanam
Eliminate the functions responsible for retrieving the individual nam…
f01b2c8 
…e components.
@Ahmed-Ghanam
Allow the user to send in the components of recipient name when creat…
93e511e 
…ing an order of any type
@Ahmed-Ghanam
Simplify the keywords detection logic
0fb50a2
@Ahmed-Ghanam
Remove the RecipientNameComponents type.
e3ceadc
@Ahmed-Ghanam
Remove the name components
8cc1283
@Ahmed-Ghanam
Remove the unnecessary ConfigureAwait
dbe1a77
@Ahmed-Ghanam
Create a new keyword service to inject actual value wherever a keywor…
a1d13ce 
…d is found
@Ahmed-Ghanam
Update the test data
ea80c49
@Ahmed-Ghanam
Update two functions to retrieve recipient number and recipient name
7c6b427
@Ahmed-Ghanam
Update the sender email address.
6ffb6db
@Ahmed-Ghanam
Save the customized email subject and body in the database
d5d264d
@Ahmed-Ghanam
Pass customized body and subject when trying to send Emails again
3feb865
@Ahmed-Ghanam
Add support for placeholder keywords in SMS
918808d
@Ahmed-Ghanam
Improve the keyword replacement logic
d1391ad
@Ahmed-Ghanam
Replace Regex checks with string.Contains
2bb8102
@Ahmed-Ghanam
Improve the request that we use to retrieve unit details.
a4fb9d5
@Ahmed-Ghanam
Add validation logic to ensure that either organizationNumber or soci…
3003630 
…alSecurityNumber is set at a time.
@Ahmed-Ghanam
Added a constructor for batch creation from existing lists to simplif…
0f3bd1c 
…y usage in client code.
@Ahmed-Ghanam
Update the function that is used to retrieve emails
7b49cbb
@Ahmed-Ghanam
Fix build errors
602b804
@Ahmed-Ghanam
Pass a default value for the new parameters
dfb5241
@Ahmed-Ghanam
Breaking a large method into smaller, more focused private methods
52b12b3
@Ahmed-Ghanam
Make a method static
26728a0
@Ahmed-Ghanam
Code refactoring
62ee16f
@Ahmed-Ghanam
Code refactoring
3f13092
@Ahmed-Ghanam
Fix typos
583d139
@Ahmed-Ghanam
Use explicit JOIN instead of the implicit join in the FROM clause and…
3763f01 
… improve indentation for better readability.
@Ahmed-Ghanam
Use explicit JOIN instead of the implicit join in the FROM clause and…
d856944 
… ensure consistent indentation for better readability.
@Ahmed-Ghanam
Use SELECT INTO for assigning values to the __orderid variable and im…
3ab7891 
…prove indentation for better readability.
@Ahmed-Ghanam
Use SELECT INTO for assigning values to the __orderid variable and im…
e0d494c 
…prove indentation for better readability.
@Ahmed-Ghanam
Add a script to alter tables
de659f9
@Ahmed-Ghanam
Undo changes made on the auto generated file and move them to new scr…
4fef97b 
…ipts
@Ahmed-Ghanam
Remove two unnecessary values.
0e94515
@Ahmed-Ghanam
Add a missing parenthesis
9320d26
@Ahmed-Ghanam
Remove two unnecessary properties.
caeae94
@Ahmed-Ghanam
Remove two unnecessary values.
1b58b0d
@Ahmed-Ghanam
Enhance the logic to ensure all existing unit tests execute successfu…
1b0385d 
…lly.
@Ahmed-Ghanam
Save and retrieve the customized subject and body to and from the dat…
adfb256 
…abase
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
31.03% Condition Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenningNormann HenningNormann Awaiting requested review from HenningNormann

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
review/domain-model-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ahmed-Ghanam