Skip to content

Commit

Permalink
Merge branch 'main' of github.com:Altinity/clickhouse-regression
Browse files Browse the repository at this point in the history
  • Loading branch information
alsugiliazova committed Sep 13, 2024
2 parents fc5433a + 55c04c2 commit c7649a9
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 17 deletions.
29 changes: 29 additions & 0 deletions aggregate_functions/regression.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
issue_58727 = "https://github.com/ClickHouse/ClickHouse/issues/58727"
issue_58741 = "https://github.com/ClickHouse/ClickHouse/issues/58741"
issue_64745 = "https://github.com/ClickHouse/ClickHouse/issues/64745"
issue_69192 = "https://github.com/ClickHouse/ClickHouse/issues/69192"

xfails = {
"/aggregate functions/singleValueOrNull/Map:": [(Fail, issue_43140)],
Expand Down Expand Up @@ -406,6 +407,34 @@
check_clickhouse_version("<22.4"),
)
],
"/aggregate functions/mannWhitneyUTest/*": [
(
Fail,
issue_69192,
check_clickhouse_version(">=24.9"),
)
],
"/aggregate functions/function_list/untested function distinctJSONPathsAndTypes": [
(
Fail,
"Tests are not implemented for distinctJSONPathsAndTypes function.",
check_clickhouse_version(">=24.9"),
),
],
"/aggregate functions/function_list/untested function distinctJSONPaths": [
(
Fail,
"Tests are not implemented for distinctJSONPaths function.",
check_clickhouse_version(">=24.9"),
),
],
"/aggregate functions/function_list/untested function distinctDynamicTypes": [
(
Fail,
"Tests are not implemented for distinctDynamicTypes function.",
check_clickhouse_version(">=24.9"),
),
],
}


Expand Down
27 changes: 10 additions & 17 deletions aggregate_functions/tests/function_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,14 @@
@Flags(TE)
def feature(self):
"""Check if new aggregate functions was not added in system.functions table."""
r = self.context.node.query(
"SELECT name FROM system.functions WHERE is_aggregate=1 and alias_to=''"
)
aggregate_functions_list = r.output.strip().split("\n")
diff = [
name for name in aggregate_functions_list if name not in aggregate_functions
]

with Check("check current aggregate function list"):
r = (
current()
.context.node.query(
"SELECT name FROM system.functions WHERE is_aggregate=1 and alias_to='' ORDER BY name"
)
.output
)
aggregate_functions_list = r.strip().split("\n")
diff = [
name for name in aggregate_functions_list if name not in aggregate_functions
]
assert len(diff) == 0, (
f"{', '.join(i for i in diff)} were added"
if len(diff) > 1
else f"{', '.join(i for i in diff)} was added"
)
for name in diff:
with Check(f"untested function {name}", flags=TE):
fail(f"Aggregate function `{name}` was added, but not tested.")

0 comments on commit c7649a9

Please sign in to comment.