Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Link Price Action Details to Coingecko URL #427

Merged
merged 3 commits into from
May 21, 2024

Conversation

Xavier-Charles
Copy link
Contributor

@Xavier-Charles Xavier-Charles commented May 20, 2024

101dff01-3135-49d5-a6e4-c0902abb8181

@Xavier-Charles Xavier-Charles marked this pull request as ready for review May 20, 2024 17:13
@v-almonacid
Copy link
Contributor

I don't understand why it was removed. It should just link to the coin in coingecko

@Xavier-Charles
Copy link
Contributor Author

I don't understand why it was removed. It should just link to the coin in coingecko

Didn't find the slug. Updated now

@Xavier-Charles Xavier-Charles changed the title Feat/alpha 5024 remove view details feat: Link Price Action Details to Coingecko URL May 21, 2024
@v-almonacid
Copy link
Contributor

I don't understand why it was removed. It should just link to the coin in coingecko

Didn't find the slug. Updated now

I assumed the BE already provided a explicit link to coingecko. My bad. I guess this is the best we can do for now

@v-almonacid v-almonacid marked this pull request as draft May 21, 2024 16:16
@v-almonacid v-almonacid marked this pull request as ready for review May 21, 2024 16:16
@v-almonacid v-almonacid merged commit d0f1d70 into dev May 21, 2024
1 check passed
@v-almonacid v-almonacid deleted the feat/ALPHA-5024-remove-view-details branch May 21, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants