feat: migrate routes to modals #406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavier-Charles
approved these changes
Apr 19, 2024
| return context; | ||
| }; | ||
|
|
||
| const MODAL_HISTORY = new Set<string>(); |
There was a problem hiding this comment.
Any benefits of putting this outside and not using a useState
There was a problem hiding this comment.
useState would be an overkill and wiould cause rerenders.
packages/frontend/src/api/store/providers/controlled-modal-provider.tsx
Outdated
Show resolved
Hide resolved
|
Great work here but, We won't be continuing with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.