Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Clicking card tags does nothing sometimes #401

Merged

Conversation

Xavier-Charles
Copy link
Contributor

Card tags should always have a slug, if they don't. Then the button would be disabled. This PR also removes the unnecessary onClick prop

@Xavier-Charles Xavier-Charles marked this pull request as ready for review April 16, 2024 14:49
Copy link
Contributor

@v-almonacid v-almonacid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xavier-Charles Xavier-Charles marked this pull request as draft April 17, 2024 11:04
@Xavier-Charles Xavier-Charles marked this pull request as ready for review April 17, 2024 11:04
@Xavier-Charles Xavier-Charles merged commit 722f692 into dev Apr 17, 2024
1 check passed
@Xavier-Charles Xavier-Charles deleted the fix/ALPHA-4975-clicking-card-Tags-does-nothing-sometimes branch April 17, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants