feat: Handle Mobile and Desktop Specific routes #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elcharitas
reviewed
Apr 10, 2024
elcharitas
reviewed
Apr 10, 2024
v-almonacid
suggested changes
Apr 11, 2024
Xavier-Charles
force-pushed
the
feat/ALPHA-4966-Alphaday-Mobile-Redirect
branch
from
695beeb
to
2d173ed
Compare
elcharitas
reviewed
Apr 16, 2024
v-almonacid
suggested changes
Apr 16, 2024
| thegraph: ["the-graph"], | ||
| trading: ["market", "trading-video", "economic-calendar"], | ||
| verasity: ["verasity", "verasity-source"], | ||
| vitalikbuterin: ["vitalki-buterin"], |
packages/frontend/src/routes.ts
Outdated
| @@ -40,6 +40,8 @@ export interface IRoute { | |||
| component: typeof ErrorPage | typeof PreloaderPage | typeof DashboardPage; | |||
| exact?: boolean; | |||
| isFullsize?: boolean; | |||
| redirectTo?: string; | |||
| type: "regular" | "redirect"; | |||
There was a problem hiding this comment.
note that this definition is inconsistent to the mobile route definition, and using a union type for type doesn't allow for runtime casting
packages/frontend/src/App.tsx
Outdated
| key={route.path} | ||
| path={route.path} | ||
| exact={route.exact} | ||
| to={route.redirectTo ?? EDesktopRoutePaths.Base} |
There was a problem hiding this comment.
if the route is of type redirect, the redirectTo field shouldn't be optional (relates to my other comment on type definition).
packages/frontend/src/MobileApp.tsx
Outdated
| const { IS_DEV } = CONFIG; | ||
| const { IS_DEV, BOARDS } = CONFIG; | ||
|
|
||
| const BoardRoutesHandler = ( |
There was a problem hiding this comment.
A function name which is not a react FC should never start with an uppercase. I keep telling you this, Charles. You are no longer a junior dev, you should pay more attention to coding style.
v-almonacid
approved these changes
Apr 17, 2024
elcharitas
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR View routes like
/b/aaveare resolved to search Routes using the board-slug map in the boards config.Also routes that contain
/superfeedare rerouted to/on desktop instead of 404