fix: ALPHA-4956 Time Range Hidden #392
Conversation
| const isTabBarHidden = !!mobileRoutes.find( | ||
| (route) => | ||
| route.type !== "fallback" && | ||
| route.path === pathname && |
There was a problem hiding this comment.
why are these 2 conditions neecessary, as opposed to just rely on the hideTabBar prop?
There was a problem hiding this comment.
The hideTabBar Prop is not present in route options with type "fallback" because, they do not have a path prop to compare against and secondly are not the final route, they lead to other well defined route options
There was a problem hiding this comment.
Fallback routes are more less redirects. You should not need to hasndle the cases specifically since they would never display
I understand what you're trying to achieve. This works
| @@ -41,95 +41,108 @@ const CustomNavTab: React.FC<{ | |||
| </div> | |||
| ); | |||
|
|
|||
| const RouterChild = () => { | |||
There was a problem hiding this comment.
Why not only extract out the TabBar?
There was a problem hiding this comment.
There is this weird error when you extract just IonTabBar. It doesn't work
This also removes the bottom Navbar for Notifications, User Settings and Auth Pages as per design
Before
After