Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Navigating to settings or filters for the first time doesn't work #387

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

elcharitas
Copy link
Member

No description provided.

@elcharitas elcharitas marked this pull request as ready for review April 5, 2024 04:20
render={() => (
<Redirect to={route.redirectTo} />
)}
<Redirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the problem or solution is here. The ticket too has no explanation.

Copy link
Member Author

@elcharitas elcharitas Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this then:

  • open a new tab on a freesh navigator
  • open the app on this tab
  • click on the filters button
  • This Pr would ensure clicking on the button navigates to filters page

Copy link
Contributor

@v-almonacid v-almonacid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Contributor

@Xavier-Charles Xavier-Charles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works.

@v-almonacid v-almonacid merged commit 0b307d9 into dev Apr 5, 2024
4 checks passed
@v-almonacid v-almonacid deleted the ALPHA-4931 branch April 5, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants