Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Can't search for more than one keyword #367

Merged

Conversation

v-almonacid
Copy link
Contributor

@v-almonacid v-almonacid commented Mar 27, 2024

Trying to do a second search gives currently no results:
Screenshot 2024-03-27 at 22 30 38

Also, after performing a search (in the filters page as well), the input text stays there, but it should be removed (in the main search bar we should only keep the selections, in the filters page we keep nothing). This is annoying because the user needs to delete those characters before performing a new search attempt:

Screenshot 2024-03-27 at 22 23 26

This PR fixes these two issues.

@v-almonacid v-almonacid marked this pull request as ready for review March 28, 2024 01:58
Copy link
Member

@elcharitas elcharitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works

Copy link
Contributor

@Xavier-Charles Xavier-Charles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@v-almonacid v-almonacid merged commit 22b95ad into dev Mar 28, 2024
1 check passed
@v-almonacid v-almonacid deleted the ALPHA-4891-cant-search-for-a-second-keyword-in-main-search-bar branch March 28, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants