feat: Add Feedback to UserProfile #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Xavier-Charles
commented
Mar 25, 2024
Xavier-Charles
commented
elcharitas
reviewed
Mar 25, 2024
| const prevIsSavingProfile = usePrevious(isSavingProfile); | ||
|
|
||
| useEffect(() => { | ||
| if (prevIsSavingProfile === true && isSavingProfile === false) { |
There was a problem hiding this comment.
Tbh I'm okay with this, but I think we can have this check and state chaneg outside of the effect,
There was a problem hiding this comment.
yes the effect looks unnecessary
elcharitas
reviewed
Mar 25, 2024
| @@ -102,6 +104,14 @@ const UserSettings: FC<IUserSettings> = ({ | |||
| const [showProfileEditModal, setShowProfileEditModal] = | |||
| useState<boolean>(false); | |||
| const history = useHistory(); | |||
| const [isProfileUpdated, setisProfileUpdated] = useState(false); | |||
There was a problem hiding this comment.
Please fix this declaration, it should be setIsProfileUpdated unless I'm missing something
v-almonacid
approved these changes
Mar 25, 2024
| isSavingProfile || | ||
| handle === undefined || | ||
| profile?.handle === handle | ||
| } |
Xavier-Charles
force-pushed
the
ALPHA-4771
branch
from
a1f2b01
to
a53a4ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.