-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Portfolio holdings details #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
const PortfolioChart: FC = () => { | ||
const assets = useMemo<TPortfolioDataForAddress["assets"]>( | ||
() => | ||
portfolioData !== undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be defined as a prop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but that's for later
subtext="Connect your wallet to get started" | ||
icon={<CopySVG className="w-[22px] mr-1" />} | ||
onClick={() => onClick("/portfolio/connect-wallet")} | ||
isAuthenticated={isAuthenticated} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: we've been told today that this option was not going to be included. But it's fine to keep it for now
import { TPortfolioDataForAddress } from "src/components/portfolio/types"; | ||
|
||
export const portfolioData: TPortfolioDataForAddress = { | ||
assets: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally we need to define a portoflio component API that is decoupled from the data API provider, but this is work for a separate PR.
}, | ||
]; | ||
return ( | ||
<IonPage className="justify-start portfolio-widget"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we use some of the mobile layout templates here?
This PR uses mock Data for now.