feat: Portfolio holdings details #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-almonacid
approved these changes
Mar 4, 2024
| const PortfolioChart: FC = () => { | ||
| const assets = useMemo<TPortfolioDataForAddress["assets"]>( | ||
| () => | ||
| portfolioData !== undefined |
There was a problem hiding this comment.
Shouldn't this be defined as a prop?
There was a problem hiding this comment.
Yeah but that's for later
| subtext="Connect your wallet to get started" | ||
| icon={<CopySVG className="w-[22px] mr-1" />} | ||
| onClick={() => onClick("/portfolio/connect-wallet")} | ||
| isAuthenticated={isAuthenticated} |
There was a problem hiding this comment.
FYI: we've been told today that this option was not going to be included. But it's fine to keep it for now
| import { TPortfolioDataForAddress } from "src/components/portfolio/types"; | ||
|
|
||
| export const portfolioData: TPortfolioDataForAddress = { | ||
| assets: [ |
There was a problem hiding this comment.
ideally we need to define a portoflio component API that is decoupled from the data API provider, but this is work for a separate PR.
| }, | ||
| ]; | ||
| return ( | ||
| <IonPage className="justify-start portfolio-widget"> |
There was a problem hiding this comment.
shouldn't we use some of the mobile layout templates here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses mock Data for now.
