Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filter search bar implementation #273

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

v-almonacid
Copy link
Contributor

No description provided.

@v-almonacid v-almonacid marked this pull request as ready for review March 1, 2024 19:36
Copy link
Contributor

@Xavier-Charles Xavier-Charles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works but I don't see the effect of the filtering on the superfeed (May be backend issue).

Also the behaviour of selecting a keyword and there is no feedback (on most phones the general section will be below the visible screen so the user does not know what just happened) should be worked on.

There is still that flicker when a keyword is selected so it's confusing. What comes to mind is a scroll effect.

Rest looks good.

@v-almonacid
Copy link
Contributor Author

This works but I don't see the effect of the filtering on the superfeed (May be backend issue).

Also the behaviour of selecting a keyword and there is no feedback (on most phones the general section will be below the visible screen so the user does not know what just happened) should be worked on.

There is still that flicker when a keyword is selected so it's confusing. What comes to mind is a scroll effect.

Rest looks good.

Noted. We'll work on that in separate PRs

@v-almonacid v-almonacid marked this pull request as draft March 4, 2024 12:42
@v-almonacid v-almonacid marked this pull request as ready for review March 4, 2024 12:42
@v-almonacid
Copy link
Contributor Author

This works but I don't see the effect of the filtering on the superfeed (May be backend issue).

regarding this, the branch was outdated and was missing a recent fix.

@v-almonacid v-almonacid merged commit bdbc994 into dev Mar 4, 2024
1 check passed
@v-almonacid v-almonacid deleted the ALPHA-4685-filter-search-bar-fe-implementation branch March 4, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants