-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement settings page #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just style issues and there is no feedback while saving the username.
We can't add toasts here. They are hidden behind the modal, and I couldn't find a way to make it work. What style issues do you see? |
|
How about a loading modal just as we have the congratulations modal after sign up. |
By usually you mean where? I did it that way first but didn't like the result. I didn't see design specs for this type of forms but I'll check the
You usually don't press enter on a mobile phone. Agree with the rest. |
A modal on top of a modal is usually not a good practice. One alternative could be to close this modal and then show a toast (or a modal as you say), but it's not the best UX IMO. |
This implements most of the user settings sections (rate us is missing).
For updating the profile we allow users to change their handle for now: