Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement settings page #268

Merged
merged 5 commits into from
Feb 29, 2024
Merged

feat: Implement settings page #268

merged 5 commits into from
Feb 29, 2024

Conversation

v-almonacid
Copy link
Contributor

@v-almonacid v-almonacid commented Feb 28, 2024

This implements most of the user settings sections (rate us is missing).
For updating the profile we allow users to change their handle for now:

image

@v-almonacid v-almonacid marked this pull request as ready for review February 28, 2024 22:53
Copy link
Contributor

@Xavier-Charles Xavier-Charles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just style issues and there is no feedback while saving the username.

@v-almonacid
Copy link
Contributor Author

Looks good. Just style issues and there is no feedback while saving the username.

We can't add toasts here. They are hidden behind the modal, and I couldn't find a way to make it work.

What style issues do you see?

@Xavier-Charles
Copy link
Contributor

What style issues do you see?

  1. We usually but the label above the text not beside it. Check the FormInput Element
  2. The Input bar should be full width
  3. Add some space between the header and the input
  4. Enter key should trigger save
  5. Reduce the space between the button and input

@Xavier-Charles
Copy link
Contributor

Looks good. Just style issues and there is no feedback while saving the username.

How about a loading modal just as we have the congratulations modal after sign up.

@v-almonacid
Copy link
Contributor Author

v-almonacid commented Feb 29, 2024

@Xavier-Charles

We usually but the label above the text not beside it. Check the FormInput Element

By usually you mean where? I did it that way first but didn't like the result. I didn't see design specs for this type of forms but I'll check the FormElement component.

Enter key should trigger save

You usually don't press enter on a mobile phone.

Agree with the rest.

@v-almonacid
Copy link
Contributor Author

Looks good. Just style issues and there is no feedback while saving the username.

How about a loading modal just as we have the congratulations modal after sign up.

A modal on top of a modal is usually not a good practice. One alternative could be to close this modal and then show a toast (or a modal as you say), but it's not the best UX IMO.

@v-almonacid
Copy link
Contributor Author

Used FormInput as suggested. Looking better. Merging for now, we'll polish later.

image

@v-almonacid v-almonacid merged commit a2b4cf5 into dev Feb 29, 2024
@v-almonacid v-almonacid deleted the ALPHA-4690 branch February 29, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants