feat: Create Portfolio #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavier-Charles
force-pushed
the
feat/ALPHA-4395-Create-Portfolio-page
branch
from
dbcf836
to
d7f3086
Compare
v-almonacid
reviewed
Feb 28, 2024
There was a problem hiding this comment.
you can remove this component if you want
| @@ -0,0 +1,7 @@ | |||
| import { TCoin } from "src/api/types"; | |||
There was a problem hiding this comment.
Any reason why this was defined here? We usually don't define types in pages/. Pages should only contain:
- a layout
- one or multiple containers that handle the data layer.
There was a problem hiding this comment.
It's just a placeholder this will be moved soon
There was a problem hiding this comment.
In those cases please add a comment (event though I don't see why not placing the code where it should already)
v-almonacid
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just UI work. I'd leave the implementation to when the APIs are ready. What's left is the main portfolio UI