Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't overlay nav bar on modals #241

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Conversation

v-almonacid
Copy link
Contributor

This is probably a temporal solution because a good fix involves re-structuring the layout and/or the navigation hierarchy.

For now it's totally fine (and maybe even the right way) to display "modal" pages over the whole screen.

image image

@v-almonacid v-almonacid marked this pull request as ready for review February 15, 2024 18:00
Copy link
Contributor

@Xavier-Charles Xavier-Charles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the right solution would be to use the PagedMobilleLayout component instead of MobileLayout for the UserFilters and also setup the routing so that its a page. It's a quick change.

Removing the zIndex may have some unprecedented effects

@v-almonacid
Copy link
Contributor Author

I think the right solution would be to use the PagedMobilleLayout component instead of MobileLayout for the UserFilters and also setup the routing so that its a page. It's a quick change.

Removing the zIndex may have some unprecedented effects

I disagree. The bottom navigation bar shouldn't be force displayed on top of the the rest of the content.
You are right in that a correct fix should be done using a good layout. But even the "paged layout" isn't a proper solution. We shouldn't handle manually "back" events for instance. That should be handled by the navigation stack which is what I'm exploring in #242.

@v-almonacid v-almonacid merged commit 65e7bc6 into dev Feb 16, 2024
1 check passed
@v-almonacid v-almonacid deleted the fix/bottom-nav-z-index branch February 16, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants