Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create User menu page #231

Merged
merged 12 commits into from
Feb 13, 2024
Merged

feat: Create User menu page #231

merged 12 commits into from
Feb 13, 2024

Conversation

Xavier-Charles
Copy link
Contributor

Screenshot 2024-02-09 at 21 38 51 Screenshot 2024-02-09 at 21 39 27

@Xavier-Charles Xavier-Charles marked this pull request as ready for review February 9, 2024 20:40
@Xavier-Charles Xavier-Charles force-pushed the feat/ALPHA-4387-Create-Settings-Page branch from 4534cb0 to 45b6b7a Compare February 9, 2024 20:42
v-almonacid
v-almonacid reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@v-almonacid v-almonacid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I'm moving mobile-specific components into /mobile-components/

v-almonacid
v-almonacid reviewed Feb 13, 2024
View reviewed changes
packages/frontend/src/components/profile/UserMenu.tsx Outdated
},
];

const UnAuthenticatedSection = () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: rename by NonAuthenticatedSection

elcharitas
elcharitas approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@elcharitas elcharitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Xavier-Charles Xavier-Charles force-pushed the feat/ALPHA-4387-Create-Settings-Page branch from 8dae72b to f00d51c Compare February 13, 2024 14:22
@Xavier-Charles Xavier-Charles merged commit 72281b2 into dev Feb 13, 2024
@Xavier-Charles Xavier-Charles deleted the feat/ALPHA-4387-Create-Settings-Page branch February 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-almonacid v-almonacid v-almonacid left review comments

@elcharitas elcharitas elcharitas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xavier-Charles @v-almonacid @elcharitas