Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Serive worker cache issues #225

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

v-almonacid
Copy link
Contributor

This PR addresses two separate issues, possibly related.

  • A caching issue in the service worker when a file is too big, in which case its caching is handled by the browser. It may occur then that the browser removes this file from the cache, causing the current issue on zetta.
  • OTOH there is the old cache issue where index.html refers to a stale index.xxx.js file. Working on the other issue I realized we need to be much more conservative and add zero caching on our index.html.

@v-almonacid v-almonacid marked this pull request as ready for review February 7, 2024 16:30
Copy link
Contributor

@faraggi faraggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great we have this now.
I assume this fixes a few of our white page errors

@v-almonacid v-almonacid merged commit a40233c into dev Feb 8, 2024
1 check passed
@v-almonacid v-almonacid deleted the ALPHA-4640-fix-crash-caused-by-stale-index branch February 8, 2024 13:47
@v-almonacid v-almonacid changed the title fix: Cache issues fix: Serive worker cache issues Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants