Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Email/SSO UI #206

Merged
merged 40 commits into from
Feb 5, 2024
Merged

feat: Implement Email/SSO UI #206

merged 40 commits into from
Feb 5, 2024

Conversation

elcharitas
Copy link
Member

@elcharitas elcharitas commented Jan 19, 2024

A few things to note:

  • This PR makes a lot of changes and comes with a migration, please inspect the migration carefully in case I missed something. Currently, what it should do is logout users completely and rest their views.
  • This PR contains work for both mobile and desktop apps. Please review both
  • This PR does not remove wallet connection apis (wallet verification) and code as these apis are tightly coupled (I know becuase I tried removing it) with our auth system. Instead, I'll create a new ticket on JIRA for next sprint to remove them all carefully.
  • Email auth works (OTP verif endpoint may be broken, I'll confirm w/Gideon today)
  • Google SSO works like magic (both mobile and desktop)
  • Apple SSO hasn't been implemented yet

To test

Navigate to http://localhost:3001/auth on mobile or click Sign In/Sign Up button in profile dropdown.

Checklist

  • - a migration which should logout users
  • - email login on mobile
  • - email login on desktop (dialog, checkable through dropdown)
  • - API Integrations for OTP, email etc
  • - Partial Support for Social login

Previews:

Screenshot 2024-01-26 at 07 35 20 Screenshot 2024-01-26 at 07 35 51 Screenshot 2024-01-26 at 07 36 18 Screenshot 2024-01-26 at 07 37 14

@elcharitas elcharitas marked this pull request as ready for review February 1, 2024 03:42
@faraggi
Copy link
Contributor

faraggi commented Feb 1, 2024

does not remove wallet connection apis

It would be preferable to not remove them, but to separate them

@faraggi
Copy link
Contributor

faraggi commented Feb 1, 2024

Hover on the login link doesn't work.
image

@faraggi
Copy link
Contributor

faraggi commented Feb 1, 2024

On epsilon, google/apple SSO doesn't work. BTW, I added epsilon to the goog oauth uris. but maybe some further config should be added?

@faraggi
Copy link
Contributor

faraggi commented Feb 1, 2024

toast with confirmation of email is behind the modal, and behind dark overlay. makes it hard to read text on the message.

@faraggi
Copy link
Contributor

faraggi commented Feb 1, 2024

Not getting email OTP. (see comment above about epsilon conf?)

Copy link
Contributor

@faraggi faraggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something going on with the email regex or its sourrounding logic, since it is bypassing my bad emails.

Copy link
Contributor

@Xavier-Charles Xavier-Charles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Johnathan I can get this to work on my end

I get this error for email
Screenshot 2024-02-01 at 12 17 03
And this for google SSO
Screenshot 2024-02-01 at 12 34 44

Copy link
Contributor

@Xavier-Charles Xavier-Charles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the initial Google Auth button doesn't work (the one with the blue outline)

@elcharitas
Copy link
Member Author

@faraggi @Xavier-Charles please a sidenote(altho late) https://github.com/AlphadayHQ/backend/pull/760 is yet to be merged.

@elcharitas
Copy link
Member Author

Also the initial Google Auth button doesn't work

This is because https://github.com/AlphadayHQ/backend/pull/760 is yet to be merged

handleBack?: () => void;
}

export const Pager: React.FC<PagerProps> = ({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a screenshot with this component to the PR description

@Xavier-Charles
Copy link
Contributor

This is because AlphadayHQ/backend#760 is yet to be merged

I mean it does nothing. The other google (white) button at least opens a new tab where I'm to choose an email. The blue button does not open a new tab

Copy link
Contributor

@Xavier-Charles Xavier-Charles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also how do you trigger auth on the mobile app?

Copy link
Contributor

@Xavier-Charles Xavier-Charles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way the migration works flawlessly

@elcharitas elcharitas merged commit 4ead60a into dev Feb 5, 2024
@elcharitas elcharitas deleted the ALPHA-4462 branch February 5, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants