-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement Email/SSO UI #206
Conversation
It would be preferable to not remove them, but to separate them |
On epsilon, google/apple SSO doesn't work. BTW, I added epsilon to the goog oauth uris. but maybe some further config should be added? |
toast with confirmation of email is behind the modal, and behind dark overlay. makes it hard to read text on the message. |
Not getting email OTP. (see comment above about epsilon conf?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something going on with the email regex or its sourrounding logic, since it is bypassing my bad emails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the initial Google Auth button doesn't work (the one with the blue outline)
@faraggi @Xavier-Charles please a sidenote(altho late) https://github.com/AlphadayHQ/backend/pull/760 is yet to be merged. |
This is because https://github.com/AlphadayHQ/backend/pull/760 is yet to be merged |
handleBack?: () => void; | ||
} | ||
|
||
export const Pager: React.FC<PagerProps> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a screenshot with this component to the PR description
I mean it does nothing. The other google (white) button at least opens a new tab where I'm to choose an email. The blue button does not open a new tab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also how do you trigger auth on the mobile app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way the migration works flawlessly
A few things to note:
To test
Navigate to http://localhost:3001/auth on mobile or click
Sign In/Sign Up
button in profile dropdown.Checklist
Previews: