Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Bar Chart Setup and styles #191

Merged
merged 4 commits into from
Jan 9, 2024
Merged

feat: Add Bar Chart Setup and styles #191

merged 4 commits into from
Jan 9, 2024

Conversation

Xavier-Charles
Copy link
Contributor

Screenshot 2024-01-04 at 17 43 47

@Xavier-Charles Xavier-Charles marked this pull request as ready for review January 8, 2024 10:22
};
};

const renderToString = (node: JSX.Element): string => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm certain we have this same util in frontend package.
Any reason why we're not importing it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cyclic importation. frontend imports components from ui-kit

Copy link
Member

@elcharitas elcharitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Superb! Great work @Xavier-Charles

@Xavier-Charles Xavier-Charles merged commit ba32b90 into dev Jan 9, 2024
1 check passed
@Xavier-Charles Xavier-Charles deleted the feat/bar-chart branch January 9, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants