Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dynamic table heights #183

Merged
merged 2 commits into from
Dec 19, 2023
Merged

fix: Dynamic table heights #183

merged 2 commits into from
Dec 19, 2023

Conversation

v-almonacid
Copy link
Contributor

There is an unknown issue that is making the child elements of a table have a clientHeight = 0:

Screen Shot 2023-12-18 at 19 33 38

Which creates this issue:
Screen Shot 2023-12-18 at 20 13 46

So this should prevent it

@v-almonacid v-almonacid marked this pull request as ready for review December 18, 2023 23:46
@v-almonacid v-almonacid merged commit 9e70ca4 into dev Dec 19, 2023
1 check passed
@v-almonacid v-almonacid deleted the fix/dynamic-table-height branch December 19, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xavier-Charles Xavier-Charles Xavier-Charles approved these changes

@elcharitas elcharitas Awaiting requested review from elcharitas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v-almonacid @Xavier-Charles