Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing HotJar config #178

Merged
merged 4 commits into from
Dec 12, 2023
Merged

fix: Add missing HotJar config #178

merged 4 commits into from
Dec 12, 2023

Conversation

Xavier-Charles
Copy link
Contributor

No description provided.

@Xavier-Charles Xavier-Charles marked this pull request as ready for review December 12, 2023 10:59
v-almonacid
v-almonacid suggested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@v-almonacid v-almonacid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't use the REACT_ prefix anymore

@faraggi faraggi merged commit f8b0325 into dev Dec 12, 2023
@faraggi faraggi deleted the fix/hotjar branch December 12, 2023 14:52
@v-almonacid
Copy link
Contributor

@faraggi remember to squash commits 🙏

@faraggi
Copy link
Contributor

faraggi commented Dec 12, 2023

@faraggi remember to squash commits 🙏

huh, anyone know why my default was changed back to non-squash?

@v-almonacid
Copy link
Contributor

@faraggi remember to squash commits 🙏

huh, anyone know why my default was changed back to non-squash?

It keeps your last choice. When doing releases on main I use merge so then I need to think about switching to squashing when merging stuff on dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faraggi faraggi faraggi approved these changes

@v-almonacid v-almonacid v-almonacid approved these changes

@elcharitas elcharitas elcharitas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xavier-Charles @v-almonacid @faraggi @elcharitas