Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use lazyRetry in dynamic imports #163

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

v-almonacid
Copy link
Contributor

No description provided.

@v-almonacid v-almonacid marked this pull request as ready for review December 4, 2023 22:22

const PreloaderPage = lazy(() => import("./pages/preloader"));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no point in lazy loading this one because it's used elsewhere in a suspense, which cannot take a lazy loaded component.

Copy link
Member

@elcharitas elcharitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @v-almonacid

@v-almonacid v-almonacid merged commit 10127b4 into dev Dec 7, 2023
1 check passed
@v-almonacid v-almonacid deleted the chore/use-lazy-retry branch December 7, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants