chore: Migrate widgets that are still using format_structure (ALPHA-4191) #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename NoItems component by CenteredBlock - Use CenteredBlock to display 'no results' instead of an inifinite spinner when data is missing or invalid
v-almonacid
changed the title
v-almonacid
commented
Dec 1, 2023
| @@ -1,25 +1,26 @@ | |||
| export * from "./agenda"; | |||
There was a problem hiding this comment.
just reorder and added agenda
v-almonacid
commented
Dec 1, 2023
| @@ -174,5 +175,11 @@ export const customDatumAsItem: (datum: TRemoteCustomDatum) => TItem = (d) => { | |||
| }, {} as TItem); | |||
| }; | |||
|
|
|||
| export const customDataAsItems: (data: TRemoteCustomData) => TItem[] = (d) => | |||
| d.map(customDatumAsItem); | |||
| export const customDataAsItems: (data: TRemoteCustomData) => TItem[] = (d) => { | |||
There was a problem hiding this comment.
this needs a proper fix in the validation functions
Xavier-Charles
approved these changes
Dec 4, 2023
| try { | ||
| return d.map(customDatumAsItem); | ||
| } catch (error) { | ||
| Logger.error("customDataAsItems: unexpected error", error); |
There was a problem hiding this comment.
Let's say this fails I think it will be helpful to know which container this error comes from.
There was a problem hiding this comment.
you are right but I don't want to add code that will need to be cleaned up later on. This should never fail (that would mean we could not trust the expected type of the function input) so I'm actually removing the try-catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concerns the following widgets:
https://github.com/AlphadayHQ/backend/pull/740 takes care of the data layer.