Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the BATS executor #55

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Add the BATS executor #55

merged 2 commits into from
Sep 12, 2023

Conversation

anfimovdm
Copy link
Contributor

@anfimovdm anfimovdm commented Sep 9, 2023 •
edited
Loading

  • Add the BATS executor class
  • Code refactoring
  • Add unit tests
  • Add github action for unit tests
  • Black/isort syntax
  • Fix config schemas

@anfimovdm anfimovdm force-pushed the issue_78 branch 2 times, most recently from b3a5594 to 8806aa3 Compare September 9, 2023 06:58
@github-actions
Copy link

github-actions bot commented Sep 9, 2023 •
edited
Loading

Total coverage

Coverage report for changed files •
FileStmtsMissCoverMissing
__init__.py10100% 
shared
   constants.py130100% 
   models.py1863282%65–68, 93–97, 103, 128–130, 132–134, 149–150, 154, 204, 266–275, 279, 288
shared/utils
   asyncssh.py701874%38, 117–123, 127, 132–134, 139, 145–148, 151
worker/executors
   base.py78494%20–21, 54, 122
   bats.py140100% 
TOTAL139177044% 

Tests Skipped Failures Errors Time
23 0 💤 0 ❌ 0 🔥 7.483s ⏱️

@anfimovdm anfimovdm force-pushed the issue_78 branch 27 times, most recently from c185a2d to b11fe0f Compare September 10, 2023 09:19
@anfimovdm anfimovdm force-pushed the issue_78 branch 10 times, most recently from 518e582 to db1e306 Compare September 10, 2023 17:14
@anfimovdm anfimovdm linked an issue Sep 11, 2023 that may be closed by this pull request
Executor: BATS executor (with ability to run in detached mode); AlmaLinux/build-system#78
Closed
@anfimovdm anfimovdm force-pushed the issue_78 branch 2 times, most recently from b793f15 to 59d408d Compare September 11, 2023 11:34
@anfimovdm
Add the BATS executor
b849ec6 
* Add the BATS executor class
* Code refactoring
* Add unit tests
* Add github action for unit tests
* Black/isort syntax
* Fix config schemas
Korulag
Korulag reviewed Sep 11, 2023
View reviewed changes
alts/shared/constants.py Outdated
'gssapi-with-mic',
'hostbased',
'publickey',
'keyboard-interactive',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we intend to support interactive SSH authorization, so 'keyboard-interactive' and 'password' methods can be removed

alts/worker/executors/base.py Outdated
@measure_stage('run_local_command')
def run_local_command(self, cmd_args: List[str]) -> CommandResult:
try:
with local.env(**self.env_vars):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're already here, please update env usage to local[self.binary_name].with_env(**self.env_vars).run(... and update plumbum library version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plumbum has already been updated to the latest version

@Korulag Korulag merged commit a125538 into master Sep 12, 2023
1 check passed
@anfimovdm anfimovdm deleted the issue_78 branch September 12, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpisarev rpisarev rpisarev left review comments

@maccelf maccelf maccelf approved these changes

@Korulag Korulag Korulag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executor: BATS executor (with ability to run in detached mode);
4 participants
@anfimovdm @rpisarev @Korulag @maccelf