Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix centos 7 x32 provision issues #101

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

Korulag
Copy link
Contributor

@Korulag Korulag commented Jul 30, 2024

Copy link

33 passed

Code Coverage Summary

Package Line Rate
alts.scheduler 0%
alts.shared 87%
alts.shared.uploaders 37%
alts.shared.utils 52%
alts.worker 6%
alts.worker.executors 73%
alts.worker.runners 28%
Summary 37% (914 / 2460)

Linter reports

Pylint report
************* Module alts.shared.models
alts/shared/models.py:352:0: C0301: Line too long (92/80) (line-too-long)
alts/shared/models.py:117:9: W0511: FIXME: Find correct way to search for certs store (fixme)
alts/shared/models.py:229:0: C0115: Missing class docstring (missing-class-docstring)

-----------------------------------
Your code has been rated at 9.87/10


Black report
--- alts/shared/models.py	2024-07-30 14:16:42.441932+00:00
+++ alts/shared/models.py	2024-07-30 14:19:02.510882+00:00
@@ -286,13 +286,13 @@
     # Build system settings
     bs_host: Optional[str] = None
     bs_tasks_endpoint: str = '/api/v1/tests/get_test_tasks/'
     bs_token: Optional[str] = None
     # Log uploader settings
-    logs_uploader_config: Optional[
-        Union[PulpLogsConfig, AzureLogsConfig]
-    ] = None
+    logs_uploader_config: Optional[Union[PulpLogsConfig, AzureLogsConfig]] = (
+        None
+    )
     uninstall_excluded_pkgs: List[str] = [
         'almalinux-release',
         'kernel',
         'dnf',
     ]
@@ -301,13 +301,13 @@
     provision_timeout: int = 600  # 10 minutes in seconds
     tests_exec_timeout: int = 1800  # 30 minutes in seconds
     deprecated_ansible_venv: str = get_abspath('~/ansible_env')
     epel_release_urls: Dict[str, str] = {
         '6': 'http://dl.fedoraproject.org/pub/archive/epel/6/x86_64/'
-             'epel-release-6-8.noarch.rpm',
+        'epel-release-6-8.noarch.rpm',
         '7': 'https://dl.fedoraproject.org/pub/archive/epel/7/x86_64/'
-             'Packages/e/epel-release-7-14.noarch.rpm',
+        'Packages/e/epel-release-7-14.noarch.rpm',
     }
     centos_baseurl: str = 'http://mirror.centos.org/centos'
     git_reference_directory: Optional[str] = None
     tests_base_dir: str = '/tests'
     package_proxy: str = ''
@@ -349,17 +349,17 @@
             'task_track_started': True,
             'task_soft_time_limit': self.task_soft_time_limit,
             'worker_prefetch_multiplier': self.worker_prefetch_multiplier,
             'worker_deduplicate_successful_tasks': self.worker_deduplicate_successful_tasks,
             'worker_max_tasks_per_child': self.worker_max_tasks_per_child,
-            'broker_transport_options': {'visibility_timeout': 36000}
+            'broker_transport_options': {'visibility_timeout': 36000},
         }
         if isinstance(self.results_backend_config, AzureResultsConfig):
             for key in (
                 'azureblockblob_container_name',
                 'azureblockblob_base_path',
-                'azure_connection_string'
+                'azure_connection_string',
             ):
                 config_dict[key] = getattr(self.results_backend_config, key)
         elif isinstance(self.results_backend_config, S3ResultsConfig):
             for key in (
                 's3_access_key_id',

Isort report
--- /code/alts/shared/models.py:before	2024-07-30 14:16:42.441932
+++ /code/alts/shared/models.py:after	2024-07-30 14:19:03.081907
@@ -7,8 +7,8 @@
     List,
     Literal,
     Optional,
+    Set,
     Union,
-    Set,
 )
 
 from pydantic import BaseModel, ConfigDict, computed_field

Bandit report
Run started:2024-07-30 14:19:03.753772

Test results:
	No issues identified.

Code scanned:
	Total lines of code: 310
	Total lines skipped (#nosec): 0
	Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
	Total issues (by severity):
		Undefined: 0
		Low: 0
		Medium: 0
		High: 0
	Total issues (by confidence):
		Undefined: 0
		Low: 0
		Medium: 0
		High: 0
Files skipped (0):

View full reports on the Job Summary page.

@Korulag Korulag merged commit 99f49d1 into master Aug 1, 2024
2 of 3 checks passed
@Korulag Korulag deleted the fix-centos7-x32-provision branch August 1, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants