Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix delete a directory failed because of rename #18687

Open
wants to merge 3 commits into
base: master-2.x
Choose a base branch
from

Conversation

gp1314
Copy link
Contributor

@gp1314 gp1314 commented Sep 5, 2024

What changes are proposed in this pull request?

  • Submit the request for canceling the Persist task when rename is executed

  • Persist to delete the created directory if the persist task fails

Why are the changes needed?

Fix deleting a directory failed because of rename.
Transmission gate: #18667

Does this PR introduce any user facing changes?

  • No changes to the user-facing api

@gp1314 gp1314 changed the title Fix the ASYNC_THROUGH write failure when renaming the directory Fix the failure to rename the directory caused by asynchronous write operations Sep 5, 2024
@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • Title is too long (79 characters). Must be at most 72 characters.
  • Commits associated with Github account: PASS

Some checks failed. Please fix the reported issues and reply
alluxio-bot, check this please
to re-run checks.

@gp1314 gp1314 changed the title Fix the failure to rename the directory caused by asynchronous write operations Fix delete a directory failed because of rename Sep 5, 2024
@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: PASS
  • Commits associated with Github account: PASS

All checks passed!

@gp1314
Copy link
Contributor Author

gp1314 commented Sep 19, 2024

@YichuanSun Could you please help core review it

@YichuanSun
Copy link
Contributor

OK, I will try when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants