Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race in LookPool may cause used Resources to be evicted #18678

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ZanderXu
Copy link

@ZanderXu ZanderXu commented Sep 2, 2024

This PR is mainly used to fix a race in LookPool.class, which may cause some used Resources to be evicted by the Evictor.

Before evicting Resources from LookPool, the Evictor should check if the to be deleted Resource changed. And This remove operation should be synced with the getResource.

@alluxio-bot
Copy link
Contributor

Thank you for your pull request.
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement (CLA).
It's all electronic and will take just a few minutes. Please download CLA form here, sign, and e-mail back to [email protected]

@alluxio-bot
Copy link
Contributor

Automated checks report:

  • PR title follows the conventions: FAIL
    • The title of the PR does not pass all the checks. Please fix the following issues:
      • First word of title ("A") is not an imperative verb. Please use one of the valid words
      • Supported title prefixes are: [WIP], [SMALLFIX], [DOCFIX]
  • Commits associated with Github account: PASS

Some checks failed. Please fix the reported issues and reply
alluxio-bot, check this please
to re-run checks.

@ZanderXu ZanderXu changed the title [BugFix] A race in LookPool may cause used Resources to be evicted Race in LookPool may cause used Resources to be evicted Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants