-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change keyPressEvent log level #993
Conversation
I support changing this to a warning so we don't generate tons of errors. However, we should still refactor the underlying code which is a mess. Up to @micahwoodard on the priority for that refactor |
Hey @alexpiet, I understand that the format check in the code is inherently complex, primarily due to the nature of the functions we aim to implement. If you have a better solution in mind, please feel free to share it and implement it! |
I think refactoring would work well with this issue. I will merge and close associated issues for now. It would be nice to clarify all the TP_ values and how they are being used to define the task performed. Maybe we can discuss in person |
Pull Request instructions:
Describe changes:
What issues or discussions does this update address?
Describe the expected change in behavior from the perspective of the experimenter
Describe any manual update steps for task computers
Was this update tested in 446/447?