-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty/initialize fields #1248
base: develop
Are you sure you want to change the base?
Empty/initialize fields #1248
Conversation
@micahwoodard Can you please review this? |
if not self.Camera_dialog.StartRecording.isChecked(): | ||
self.Camera_dialog.camera_start_time='' | ||
self.Camera_dialog.camera_stop_time='' | ||
# clear fiber start and end time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite know the downstream effect but would these variables be better initialized as None? seems weird to me that they are just empty stings but maybe that is what the code is expecting downstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also does this fix #1124?
self.Camera_dialog.camera_stop_time='' | ||
# clear fiber start and end time | ||
if hasattr(self, 'fiber_photometry_end_time'): | ||
del self.fiber_photometry_end_time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we deleting this one and not clearing it like the others?
if not self.StartExcitation.isChecked(): | ||
if hasattr(self, 'fiber_photometry_start_time'): | ||
del self.fiber_photometry_start_time | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question here
Pull Request instructions:
Describe changes:
Clear/initialize some fields when starting a new session.
What issues or discussions does this update address?
To clear or initialize certain fields from previous sessions when the new session is started without restarting the GUI. These fields may interfere with the generation of the manifest file if not reset.
Describe the expected change in behavior from the perspective of the experimenter
No
Describe any manual update steps for task computers
No
Was this update tested in 446/447?
Tested on 323_Ephys3