Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating fip_df to use new format #44

Merged
merged 6 commits into from
Sep 11, 2024
Merged

updating fip_df to use new format #44

merged 6 commits into from
Sep 11, 2024

Conversation

alexpiet
Copy link
Collaborator

@alexpiet alexpiet commented Sep 11, 2024 •
edited
Loading

Was previously looking for acqusitions with format G_1_preprocssed, now looking for G_1_dff-exp

@alexpiet
Copy link
Collaborator Author

@rachelstephlee @hanhou This is ready for review

rachelstephlee
rachelstephlee approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@rachelstephlee rachelstephlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks for updating this.

@rachelstephlee
Copy link
Collaborator

@irisstone just making sure that you aren't fixing htis because alex seemed to have addressed it.

@alexpiet alexpiet merged commit 719057b into main Sep 11, 2024
3 checks passed
@alexpiet alexpiet deleted the fip_update branch November 13, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachelstephlee rachelstephlee rachelstephlee approved these changes

@hanhou hanhou Awaiting requested review from hanhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpiet @rachelstephlee