Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Path or str type #24

Merged
merged 1 commit into from
Oct 25, 2024
Merged

feat: use Path or str type #24

merged 1 commit into from
Oct 25, 2024

Conversation

jtyoung84
Copy link
Contributor

Closes #23

  • Creates PathLike type to handle str or Paths
  • Parses strings to Paths when EtlJob is initialized

@jtyoung84 jtyoung84 requested a review from galenlynch October 25, 2024 00:54
galenlynch
galenlynch approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@galenlynch galenlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@jtyoung84 jtyoung84 merged commit 472743c into main Oct 25, 2024
4 checks passed
@jtyoung84 jtyoung84 deleted the feat-23-str-path branch October 25, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galenlynch galenlynch galenlynch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Union[Path, str] instead of Path for JobSettings model
2 participants
@jtyoung84 @galenlynch