Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds new fields to template #95

Merged
merged 5 commits into from
Apr 29, 2024
Merged

feat: adds new fields to template #95

merged 5 commits into from
Apr 29, 2024

Conversation

jtyoung84
Copy link
Contributor

@jtyoung84 jtyoung84 commented Apr 28, 2024 •
edited
Loading

Closes #94
Closes #93

  • Needs Feat 224 project names aind-metadata-service#225 to be merged first
  • Adds column for processor_full_name
  • Adds column for project_name
  • Adds column for optional process_capsule_id
  • Modifies job_template download to pull project_names from aind-metadata-service

arielleleon
arielleleon approved these changes Apr 29, 2024
View reviewed changes
Copy link

@arielleleon arielleleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. On my end, I will need to update how to map current LIMS project codes to the correct project name. I am working with PIs on that right now. Thanks for doing this work so fast!

jtyoung84
jtyoung84 commented Apr 29, 2024
View reviewed changes
tests/test_server.py Outdated Show resolved Hide resolved
helen-m-lin
helen-m-lin requested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@helen-m-lin helen-m-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Can we update the usage instructions and example in the README and add AIND_PROJECT_NAMES_URL?

Lastly, I am unable to see the project_names validation dropdown in the downloaded template. Will discuss offline.

src/aind_data_transfer_service/configs/job_upload_template.py Outdated Show resolved Hide resolved
tests/resources/job_upload_template.xlsx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I open this locally, Excel removes project_name validation dropdown.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the validator from the template

@jtyoung84 jtyoung84 requested a review from helen-m-lin April 29, 2024 21:53
helen-m-lin
helen-m-lin approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@helen-m-lin helen-m-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested locally.

src/aind_data_transfer_service/templates/index.html Outdated Show resolved Hide resolved
src/aind_data_transfer_service/templates/job_status.html Show resolved Hide resolved
@jtyoung84 jtyoung84 merged commit 0189ba0 into main Apr 29, 2024
3 checks passed
@jtyoung84 jtyoung84 deleted the feat-93-add-fields branch April 29, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielleleon arielleleon arielleleon approved these changes

@helen-m-lin helen-m-lin helen-m-lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jtyoung84 @helen-m-lin @arielleleon