Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat 50: Dynamically generate job template #73

Merged
merged 11 commits into from
Feb 9, 2024
Merged

Conversation

helen-m-lin
Copy link
Contributor

closes #50

  • Created JobUploadTemplate class to configure and create job upload template xlsx file
    • Note: there will be a future ticket to convert this class to a pydantic model
  • Created /api/job_upload_template endpoint to download template as xlsx file
    • Note: this endpoint generates a new xlsx file stream everytime; there will be a future ticket to add caching.
  • Updated "Job Submit Template" links/ tabs in UI
  • Added unit tests and new test suite as appropriate

@jtyoung84
Copy link
Contributor

  • Note: this endpoint generates a new xlsx file stream everytime; there will be a future ticket to add caching.

I tested it out and it's probably quick enough to not need caching.

@helen-m-lin helen-m-lin requested a review from jtyoung84 February 9, 2024 17:06
@jtyoung84 jtyoung84 merged commit 21760c1 into main Feb 9, 2024
3 checks passed
@jtyoung84 jtyoung84 deleted the feat-50-job-template branch February 9, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamically generate job template
2 participants