Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds input data mount field #116

Merged
merged 2 commits into from
Jun 5, 2024
Merged

feat: adds input data mount field #116

merged 2 commits into from
Jun 5, 2024

Conversation

jtyoung84
Copy link
Contributor

Closes #111

  • Allows users to define an input mount field when submitting a custom pipeline id to run
  • Will still need to update airflow to forward this to the code ocean request

helen-m-lin
helen-m-lin requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@helen-m-lin helen-m-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add input_data_mount to index.html so it shows up in the validated jobs table?

Everything else looks good. Tested locally.

@jtyoung84
Copy link
Contributor Author

Do we need to add input_data_mount to index.html so it shows up in the validated jobs table?

Everything else looks good. Tested locally.

Good catch. Added that in the index.html file.

@jtyoung84 jtyoung84 requested a review from helen-m-lin June 5, 2024 23:21
@jtyoung84 jtyoung84 merged commit 61b349b into main Jun 5, 2024
3 checks passed
@jtyoung84 jtyoung84 deleted the feat-111-input-mount branch June 5, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielleleon arielleleon arielleleon approved these changes

@helen-m-lin helen-m-lin helen-m-lin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mount field to process new data assets in a pipeline
3 participants
@jtyoung84 @helen-m-lin @arielleleon