add axis input to reset ring buffer #60
Open
+385
−249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Poofjunior please take a look at this when you have a chance? I changed the functionality of the ring buffer based on the tigerbox for the new exaspim system. I also added set/get functions for the backlash parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Poofjunior when you have a chance please take a look at this PR. On the new ExA-SPIM system, the Tiger hardware axis that is being triggered for ring buffer moves is the Z axis (on a ZF card) (it is X axis on an XY card for the original system). For some reason, the original
reset_ring_buffercommand executes but does not actually reset the ring buffer. The solution is to allow an optionalaxisinput arg, i.e.axis=Zfor the new system. If no axis is given, the function behaves as previously.