Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/test-igor-rebase-exec-workflow.yml: Fix it for the … #2310

Merged

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Dec 15, 2024

…release branch

In c3e7dc3 (.github/workflows: Add job to compile test each commit, 2023-12-22) we introduced a compilation test of each commit in the branch. But we assumed that the base branch, the branch we want to merge into, is origin/main. This is not true for the release branches.

As there is no way to gather the base branch for on.push workflows 1 we added some code to get the release branch with the highest version and then check if we are an ancestor of that or origin/main.

@t-b t-b self-assigned this Dec 15, 2024
@t-b t-b force-pushed the bugfix/2310-fix-compilation-each-commit-for-release-branch branch from daeead7 to 7f44a16 Compare December 15, 2024 12:39
…release branch

In c3e7dc3 (.github/workflows: Add job to compile test each commit,
2023-12-22) we introduced a compilation test of each commit in the branch.
But we assumed that the base branch, the branch we want to merge into, is
origin/main. This is not true for the release branches.

As there is no way to gather the base branch for on.push workflows [1] we
added some code to get the release branch with the highest version and
then check if we are an ancestor of that or origin/main.

[1]: https://github.com/orgs/community/discussions/26243#discussioncomment-3250924
@t-b t-b force-pushed the bugfix/2310-fix-compilation-each-commit-for-release-branch branch from 7f44a16 to e97af7a Compare December 15, 2024 12:58
@t-b t-b merged commit 605d7d6 into main Dec 15, 2024
9 checks passed
@t-b t-b deleted the bugfix/2310-fix-compilation-each-commit-for-release-branch branch December 15, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant