Fix nwb_version so that dandi can read it #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-b
force-pushed
the
bugfix/2254-nwb-export
branch
2 times, most recently
from
4d16c57 to
5179e47
Compare
|
@nrsc Can you try with this version of MIES? It should create files which pass dandi validate in this regard. You can grab the installer, BuildInstaller-user-assets, from https://github.com/AllenInstitute/MIES/actions/runs/10738308861?pr=2254 |
t-b
force-pushed
the
bugfix/2254-nwb-export
branch
from
5179e47 to
71a3484
Compare
We now use debian bookworm, update the Dockerfile to use our usual conventions and use requirements.txt with hashes.
Upgrade to debian bookworm and use our usual conventions.
Update to debian bookworm.
Use debian bookworm, avoid deprecated MAINTAINER command and use requirements.txt with hashes.
This should catch issues like in the last commit earlier.
t-b
force-pushed
the
bugfix/2254-nwb-export
branch
from
71a3484 to
7214dff
Compare
We don't want to find nwb files from e.g. Packages/Basic/input as these might not pass pynwb/dandi validation anymore.
t-b
force-pushed
the
bugfix/2254-nwb-export
branch
from
7214dff to
683bbe4
Compare
timjarsky
approved these changes
Sep 9, 2024
|
I'm merging now as we have CI which checks for the issue so manual testing by @nrsc should not be necessary. |
|
Hi @t-b, apologies for the time away. I'm going to pull the executable and reinstall, then run the export to test the validation. Cheers |
No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dandi.exe validate --ignore '(NWBI|DANDI)' XXXClose #2243
Close #1988