Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vs per formula #1923

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Make vs per formula #1923

merged 2 commits into from
Nov 1, 2023

Conversation

t-b
Copy link
Collaborator

@t-b t-b commented Oct 24, 2023

Close #1809
Close #1627

t-b added 2 commits October 24, 2023 20:22
@t-b
Packages/doc/analysis-function-writing.rst: Fix list formatting
8f1db22
@t-b
SF_FormulaPlotter: Change how vs is treated
33c166b 
Since forever we have treated `vs` as x-formula for all y-formulas
combined with `with` statments.

This makes it impossible to use different x-formulas for different
y-formulas in the same graph.

We now, with a breaking change, treat `vs` as belonging to the single
y-formula left to it.
@t-b t-b assigned t-b and timjarsky and unassigned t-b Oct 24, 2023
@t-b t-b marked this pull request as ready for review October 25, 2023 14:42
@t-b t-b requested a review from timjarsky as a code owner October 25, 2023 14:42
@timjarsky
Copy link
Collaborator

@t-b Nice!

@timjarsky timjarsky assigned t-b and unassigned timjarsky Nov 1, 2023
@t-b t-b merged commit 39e0039 into main Nov 1, 2023
16 checks passed
@t-b t-b deleted the feature/1923-sweepformula-with-vs-change branch November 1, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timjarsky timjarsky timjarsky approved these changes

Assignees

@t-b t-b

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@t-b @timjarsky