Fix: Testpulse calculation failed if TP data is NaN #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case the test pulse data is completely NaN WaveStats can not determine V_minRowLoc and V_maxRowLoc and returns a -1 in both. This index was used unchecked and resulted in a RTE for invalid wave index access. This is now checked properly and NaN is returned for "instantaneous". since c5ed168 (TP_TSAnalysis: Change the way we calculate the instantaneous resistance, 2022-09-02)
|
@t-b I could use some input here, as I can not reproduce the failing test with NI hardware. It does not seem to run in the TP analysis function. |
t-b
approved these changes
Oct 24, 2023
|
@MichaelHuth I don't think the test failure is real. I've approved and restarted the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case the test pulse data is completely NaN WaveStats can not determine V_minRowLoc and V_maxRowLoc and returns a -1 in both. This index was used unchecked and resulted in a RTE for invalid wave index access.
This is now checked properly and NaN is returned for "instantaneous".
since
c5ed168 (TP_TSAnalysis: Change the way we calculate the instantaneous resistance, 2022-09-02)