Tests/CheckDashboard: Ensure we don't have legacy early abort DAC mes…

…sages present

Via CommonAnalysisFunctionChecks which we call at the end of each analysis
function test we already enforce that we have a valid dashboard pass/fail
message.

But since 8657a24 (AD_GetPerSweepFailMessage/AD_GetBaselineFailMsg:
Handle user aborted sweeps better, 2023-05-30) we try harder to also
detect early stopped sweeps prior to 87f9cbf (DAQ: Add stopping reason to
the labnotebook, 2021-05-13).

But we don't want to have the legacy sweep stop message present in any of
the tests of our analysis functions. As that always indicates a gap in the
dashboard evaluation.

Packages/MIES/MIES_AnalysisFunctions_Dashboard.ipf

@@ -1116,7 +1116,7 @@ static Function/S AD_HasPrematureStopLegacy(WAVE numericalValues, WAVE/T textual
 			FindValue/FNAN/R AD
 
 			if(V_Value >= 0)
-				return "DAQ was stopped early (n.a.)"
+				return DAQ_STOPPED_EARLY_LEGACY_MSG
 			endif
 		endif
 	endfor

Packages/MIES/MIES_Constants.ipf

@@ -1686,6 +1686,7 @@ StrConstant BUFFEREDDRAWDDAQAXES = "dDAQAxes"
 StrConstant TP_PROPERTIES_HASH = "TestPulsePropertiesHash"
 
 StrConstant DASHBOARD_PASSING_MESSAGE = "Pass"
+StrConstant DAQ_STOPPED_EARLY_LEGACY_MSG = "DAQ was stopped early (n.a.)"
 
 Constant MAX_DOUBLE_PRECISION = 15
 

Packages/tests/UTF_HardwareHelperFunctions.ipf

@@ -517,7 +517,7 @@ End
 
 static Function CheckDashboard(string device, WAVE headstageQC)
 
-	string databrowser
+	string databrowser, message
 	variable numEntries, i, state
 
 	databrowser = DB_FindDataBrowser(device)
@@ -534,8 +534,14 @@ static Function CheckDashboard(string device, WAVE headstageQC)
 	CHECK_GT_VAR(numEntries, 0)
 
 	for(i = 0; i < numEntries; i += 1)
-		state = !cmpstr(listWave[i][%Result], DASHBOARD_PASSING_MESSAGE)
+		message = listWave[i][%Result]
+		state = !cmpstr(message, DASHBOARD_PASSING_MESSAGE)
 		CHECK_EQUAL_VAR(state, headstageQC[i])
+
+		if(!headstageQC[i])
+			INFO("Index=%g, state=%g, message=%s", n0 = i, n1 = state, s0 = message)
+			CHECK_EQUAL_VAR(strsearch(message, DAQ_STOPPED_EARLY_LEGACY_MSG, 0), -1)
+		endif
 	endfor
 End